✨ Add validations to AWSCluster #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
detiber
reviewed
Mar 31, 2020
ncdc
reviewed
Mar 31, 2020
- Validates Region, ControlPlaneLoadBalancer, ControlPlaneEndpoint, and Bastion - Bastion can be added but not removed
benmoss
force-pushed
the
cluster-validation
branch
from
d76974a to
90d606b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
Removed the bastion validation |
|
/test pull-cluster-api-provider-aws-e2e |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds validations to AWSCluster. I accidentally stumbled upon the fact that
regionwas mutable, and the controller gets into a bad state if it's changed.I realized upon implementing this that it's rather difficult to enforce validations on
networkSpecsince it is repeatedly updated by the CAPA controller during reconciliation. I decided to punt on that since it was starting to turn into a much more complicated problem.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1673